Close batch pipeline after a query error#2391
Merged
Merged
Conversation
bonnefoa
force-pushed
the
pipeline-close-error
branch
from
8d0a39f to
75d3e97
Compare
Currently, if a batch ends with a statement_timeout on a br.Query(), the next br.Close() will only return the query error and leave the underlying pipeline opened. This prevents the connection from being reused and a second br.Close() is required to really close the pipeline. This patch changes br.Close() to fallthrough and close the pipeline, even with a lastRow error present.
bonnefoa
force-pushed
the
pipeline-close-error
branch
from
75d3e97 to
452f07b
Compare
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if a batch ends with a statement_timeout on a br.Query(), the next br.Close() will only return the query error and leave the underlying pipeline opened. This prevents the connection from being reused and a second br.Close() is required to really close the pipeline.
This patch changes br.Close() to fallthrough and close the pipeline, even with a lastRow error present.